feat(shell): improve shell detection with direct environment checks#24
Merged
Conversation
This commit enhances the shell auto-detection logic to be more reliable by checking shell-specific environment variables before falling back to the generic SHELL variable. The changes prioritize direct shell indicators over the login shell setting. **Shell detection improvements:** * Added direct detection for Fish shell via `$FISH_VERSION` environment variable, which is set by Fish itself and is more reliable than parsing `$SHELL` * Added direct detection for Nushell via `$NU_VERSION` environment variable * Reordered detection logic to check shell-specific variables first (`$FISH_VERSION`, `$NU_VERSION`) before falling back to `$SHELL` and `$PSModulePath` * Added inline documentation explaining the detection order and rationale for each check
benbenbang
enabled auto-merge (squash)
March 27, 2026 19:32
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enhances the shell auto-detection logic to be more reliable by checking shell-specific environment variables before falling back to the generic SHELL variable. The changes prioritize direct shell indicators over the login shell setting.
Shell detection improvements:
$FISH_VERSIONenvironment variable, which is set by Fish itself and is more reliable than parsing$SHELL$NU_VERSIONenvironment variable$FISH_VERSION,$NU_VERSION) before falling back to$SHELLand$PSModulePath